490329 - Cycle arrow buttons/icon in folderpane header are too small

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Thunderbird 3.0b3pre 20090426 - default theme

The small arrow buttons in folderpane header have only a few (maybe 8?) pixel width. They are hard to use. BTW they should be arranged left ( < ) and ( > ) right of the text.

Comment 1

[Wayne Mery (:wsmwk)]

it is a tad subtle.  I thought we had a bug on this, but not finding one

Comment 2

[Wayne Mery (:wsmwk)]

Attachment: folder pane arrows on XP at 1680 x 1050

1680 x 1050 is getting pretty high reso. 
still, I'd expect the arrows to be more visible

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Aero cycle-arrows

Folder pane arrows on Vista (Aero Theme) at 1280 x 1024 px

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

those are tiny buttons, I wonder what happened there.  We seem normal on Mac and Linux.  The XP arrows look ok to me as well, however the Vista ones are really broken somehow.

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

AFAIR this was broken _before_ the aero theme separation.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

cool, at least we have a way to fix it now :)

Does the Dom Inspector tell you anything interesting about those buttons?

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Not really. The CSS is in classic/aero/messenger/mailWindow1.css:

.folderview-cycler {
  -moz-padding-end: 0px !important;
}

Increasing the padding would fix the too small buttons:

.folderview-cycler {
  -moz-padding-start: 5px !important;
  -moz-padding-end: 5px !important;
}

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #7)
> Not really. The CSS is in classic/aero/messenger/mailWindow1.css:
> 
> .folderview-cycler {
>   -moz-padding-end: 0px !important;
> }
> 
> Increasing the padding would fix the too small buttons:
> 
> .folderview-cycler {
>   -moz-padding-start: 5px !important;
>   -moz-padding-end: 5px !important;
> }

Thanks for taking a look at this Alexander!

Once we get the separate mailWindow1-aero.css from bug 494430 then this is an easy fix.  I just removed the folderview-cycler padding entry and the buttons increase to a 9px width.  I'm not sure what's normal though.

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Ok, I'm not going to wait on bug 494430 anymore and will just try to get this fixed now.  Patch coming...

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: patch from bug 494430 converted to just fix this issue

I really wish I had XP now because I didn't get to test out why the existing mailWindow1.css needs the !important flag for the .folderview-cycler selector.

It's possible that this patch is more a matter of removing that selector altogether.

Or we could at least remove the !important superstitions such that my patch doesn't have to use it as well.

If we commit this patch, then the existing patch in bug 494430 will have to be redone, but it won't exactly be aeronautical engineering to do it.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #7)
> Increasing the padding would fix the too small buttons:
> 
> .folderview-cycler {
>   -moz-padding-start: 5px !important;
>   -moz-padding-end: 5px !important;
> }

Oh, and I meant to thank Alexander in the commit message for this snippet that I used.

Comment 12

[Phil Ringnalda (:philor)]

Sorry for the delay, that's about how long it takes my XP VM to build ;)

You can drop the the !important - whatever it was for is gone, assuming it ever existed. Fun fact that I'm going to completely ignore until someone (who is not you) both reports it and patches it: XP Classic is at least as broken as Vista+ Aero, it's really only XP Luna that actually works.

Comment 13

[Phil Ringnalda (:philor)]

Comment on attachment 398042 [details] [diff] [review]
patch from bug 494430 converted to just fix this issue

I'll be happy to (quickly, so it doesn't rot like this one did) r+a the non-!important patch.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: updated patch with comments addressed

> You can drop the the !important - whatever it was for is gone, assuming it ever
> existed. Fun fact that I'm going to completely ignore until someone (who is not
> you) both reports it and patches it: XP Classic is at least as broken as Vista+
> Aero, it's really only XP Luna that actually works.

All sorts of good things to hear! ;)

Here's the new patch, thanks for getting your XP running again.

Comment 15

[Phil Ringnalda (:philor)]

Comment on attachment 399410 [details] [diff] [review]
updated patch with comments addressed

Sorry, my comment was unclear enough to confuse you into forgetting what you already knew in comment 10. What I meant was that you could remove your !important in mailWindow1-aero.css, that you needed (at least one of) to override the !important in mailWindow1.css, by also removing the !important in mailWindow1.css, because it isn't needed by XP.

Comment 16

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: actually address the review comments, not my mixed up interpretations

i can haz right patch?

Comment 17

[Phil Ringnalda (:philor)]

Comment on attachment 399552 [details] [diff] [review]
actually address the review comments, not my mixed up interpretations

DO WANT!

Comment 18

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/b5d18d70de81